linux-kernel - Re: [PATCH v4 2/2] ACPI: NUMA: Apply SRAT proximity domain to entire CFMWS window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <735d3933-72ea-bbe6-be3b-767b3e44d837@intel.com>
Date:   Thu, 7 Sep 2023 14:42:05 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     alison.schofield@...el.com,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Mike Rapoport <rppt@...nel.org>
Cc:     x86@...nel.org, linux-cxl@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Derick Marks <derick.w.marks@...el.com>
Subject: Re: [PATCH v4 2/2] ACPI: NUMA: Apply SRAT proximity domain to entire
 CFMWS window

On 7/10/23 13:02, alison.schofield@...el.com wrote:
> +	/*
> +	 * The SRAT may have already described NUMA details for all,
> +	 * or a portion of, this CFMWS HPA range. Extend the memblks
> +	 * found for any portion of the window to cover the entire
> +	 * window.
> +	 */
> +	if (!numa_fill_memblks(start, end))
>  		return 0;

FWIW, the pieces didn't really fit together for me for this pair of
patches until I read *this* comment.

Either way:

Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>