linux-kernel - Re: [PATCH -next] scsi: ufs: core: Simplify bool conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2c7f484-0fd5-43e0-b27a-41f1b23c6932@acm.org>
Date:   Thu, 7 Sep 2023 15:47:44 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Yang Li <yang.lee@...ux.alibaba.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     alim.akhtar@...sung.com, avri.altman@....com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] scsi: ufs: core: Simplify bool conversion

On 9/6/23 17:54, Yang Li wrote:
> ./drivers/ufs/core/ufshcd.c:2307:26-31: WARNING: conversion to bool not needed here
> 
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   drivers/ufs/core/ufshcd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index c2df07545f96..04bbe38ffd87 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -2304,7 +2304,7 @@ static inline bool ufshcd_ready_for_uic_cmd(struct ufs_hba *hba)
>   	int ret = read_poll_timeout(ufshcd_readl, val, val & UIC_COMMAND_READY,
>   				    500, UIC_CMD_TIMEOUT * 1000, false, hba,
>   				    REG_CONTROLLER_STATUS);
> -	return ret == 0 ? true : false;
> +	return ret == 0;
>   }

Reviewed-by: Bart Van Assche <bvanassche@....org>