linux-kernel - arch/x86/kvm/smm.c:215 enter_smm() warn: inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202309070828.4OVHiaEQ-lkp@intel.com>
Date:   Thu, 7 Sep 2023 08:35:13 +0800
From:   kernel test robot <lkp@...el.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Maxim Levitsky <mlevitsk@...hat.com>
Subject: arch/x86/kvm/smm.c:215 enter_smm() warn: inconsistent indenting

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7ba2090ca64ea1aa435744884124387db1fac70f
commit: c53da4f3af6e613e82f88abc6eb988e44c5dadd7 KVM: x86: move SMM entry to a new file
date:   10 months ago
config: i386-randconfig-141-20230907 (https://download.01.org/0day-ci/archive/20230907/202309070828.4OVHiaEQ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230907/202309070828.4OVHiaEQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309070828.4OVHiaEQ-lkp@intel.com/

smatch warnings:
arch/x86/kvm/smm.c:215 enter_smm() warn: inconsistent indenting

vim +215 arch/x86/kvm/smm.c

   194	
   195	void enter_smm(struct kvm_vcpu *vcpu)
   196	{
   197		struct kvm_segment cs, ds;
   198		struct desc_ptr dt;
   199		unsigned long cr0;
   200		char buf[512];
   201	
   202		memset(buf, 0, 512);
   203	#ifdef CONFIG_X86_64
   204		if (guest_cpuid_has(vcpu, X86_FEATURE_LM))
   205			enter_smm_save_state_64(vcpu, buf);
   206		else
   207	#endif
   208			enter_smm_save_state_32(vcpu, buf);
   209	
   210		/*
   211		 * Give enter_smm() a chance to make ISA-specific changes to the vCPU
   212		 * state (e.g. leave guest mode) after we've saved the state into the
   213		 * SMM state-save area.
   214		 */
 > 215		static_call(kvm_x86_enter_smm)(vcpu, buf);
   216	
   217		kvm_smm_changed(vcpu, true);
   218		kvm_vcpu_write_guest(vcpu, vcpu->arch.smbase + 0xfe00, buf, sizeof(buf));
   219	
   220		if (static_call(kvm_x86_get_nmi_mask)(vcpu))
   221			vcpu->arch.hflags |= HF_SMM_INSIDE_NMI_MASK;
   222		else
   223			static_call(kvm_x86_set_nmi_mask)(vcpu, true);
   224	
   225		kvm_set_rflags(vcpu, X86_EFLAGS_FIXED);
   226		kvm_rip_write(vcpu, 0x8000);
   227	
   228		cr0 = vcpu->arch.cr0 & ~(X86_CR0_PE | X86_CR0_EM | X86_CR0_TS | X86_CR0_PG);
   229		static_call(kvm_x86_set_cr0)(vcpu, cr0);
   230		vcpu->arch.cr0 = cr0;
   231	
   232		static_call(kvm_x86_set_cr4)(vcpu, 0);
   233	
   234		/* Undocumented: IDT limit is set to zero on entry to SMM.  */
   235		dt.address = dt.size = 0;
   236		static_call(kvm_x86_set_idt)(vcpu, &dt);
   237	
   238		kvm_set_dr(vcpu, 7, DR7_FIXED_1);
   239	
   240		cs.selector = (vcpu->arch.smbase >> 4) & 0xffff;
   241		cs.base = vcpu->arch.smbase;
   242	
   243		ds.selector = 0;
   244		ds.base = 0;
   245	
   246		cs.limit    = ds.limit = 0xffffffff;
   247		cs.type     = ds.type = 0x3;
   248		cs.dpl      = ds.dpl = 0;
   249		cs.db       = ds.db = 0;
   250		cs.s        = ds.s = 1;
   251		cs.l        = ds.l = 0;
   252		cs.g        = ds.g = 1;
   253		cs.avl      = ds.avl = 0;
   254		cs.present  = ds.present = 1;
   255		cs.unusable = ds.unusable = 0;
   256		cs.padding  = ds.padding = 0;
   257	
   258		kvm_set_segment(vcpu, &cs, VCPU_SREG_CS);
   259		kvm_set_segment(vcpu, &ds, VCPU_SREG_DS);
   260		kvm_set_segment(vcpu, &ds, VCPU_SREG_ES);
   261		kvm_set_segment(vcpu, &ds, VCPU_SREG_FS);
   262		kvm_set_segment(vcpu, &ds, VCPU_SREG_GS);
   263		kvm_set_segment(vcpu, &ds, VCPU_SREG_SS);
   264	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki