linux-kernel - Re: [PATCH] proc: fix smaps_rollup test after KSM changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <77404164-a56d-8627-bdd0-42c82661fb3d@redhat.com>
Date:   Thu, 7 Sep 2023 13:15:51 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Alexey Dobriyan <adobriyan@...il.com>, akpm@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org, Stefan Roesch <shr@...kernel.io>
Subject: Re: [PATCH] proc: fix smaps_rollup test after KSM changes

On 07.09.23 13:10, Alexey Dobriyan wrote:

Can you clarify in the patch description that we are fixing up a selftest?

"selftests/proc: fixup proc-empty-vm test"

or similar?

> /proc/${pid}/smaps_rollup is not empty file even if process's address
> space is empty, update the test.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
> 
>   tools/testing/selftests/proc/proc-empty-vm.c |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- a/tools/testing/selftests/proc/proc-empty-vm.c
> +++ b/tools/testing/selftests/proc/proc-empty-vm.c
> @@ -267,6 +267,7 @@ static const char g_smaps_rollup[] =
>   "Private_Dirty:         0 kB\n"
>   "Referenced:            0 kB\n"
>   "Anonymous:             0 kB\n"
> +"KSM:                   0 kB\n"
>   "LazyFree:              0 kB\n"
>   "AnonHugePages:         0 kB\n"
>   "ShmemPmdMapped:        0 kB\n"
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb