linux-kernel - Re: [PATCH 2/3] scsi: ufs: core: allow host driver to enable wb buffer resize function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e39a18d2-7abe-4de8-a57c-980f859d79df@acm.org>
Date:   Thu, 7 Sep 2023 06:45:31 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Lu Hongfei <luhongfei@...o.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        Can Guo <quic_cang@...cinc.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Asutosh Das <quic_asutoshd@...cinc.com>,
        Po-Wen Kao <powen.kao@...iatek.com>,
        Eric Biggers <ebiggers@...gle.com>,
        Arthur Simchaev <Arthur.Simchaev@....com>,
        Keoseong Park <keosung.park@...sung.com>,
        linux-kernel@...r.kernel.org
Cc:     opensource.kernel@...o.com
Subject: Re: [PATCH 2/3] scsi: ufs: core: allow host driver to enable wb
 buffer resize function

On 9/7/23 00:35, Lu Hongfei wrote:
> Since UFS4.1 will support the WB buffer resize function, the host could
> choose to enable or disable it as needed.
> 
> Introduce a flag UFSHCD_CAP_WB_BUF_RESIZE to provide the host with the
> ability to enable or disable WB buffer resize function.
> 
> UFSHCD_CAP_WB_BUF_RESIZE is only valid when UFSHCD_CAP_WB_EN is set.

Please drop this patch. It should be sufficient that WB buffer resizing
can be controlled via sysfs. I don't think that the host driver should
be able to decide whether or not this functionality is enabled.

Additionally, when reposting this patch series, please include a cover
letter such that e-mail clients that support threading group these
patches into a series.

Thanks,

Bart.