linux-kernel - Re: [PATCH] mcb: fix error handling for different scenarios when parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e8d98a0-9111-86e5-38e5-bfa4beb6d1ba@huawei.com>
Date:   Thu, 7 Sep 2023 09:31:31 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     Sanjuán García, Jorge 
        <Jorge.SanjuanGarcia@...gon.com>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>
CC:     "morbidrsa@...il.com" <morbidrsa@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jth@...nel.org" <jth@...nel.org>,
        Rodríguez Barbarin, José Javier 
        <JoseJavier.Rodriguez@...gon.com>
Subject: Re: [PATCH] mcb: fix error handling for different scenarios when
 parsing


On 2023/9/6 22:36, Sanjuán García, Jorge wrote:
> chameleon_parse_gdd() may fail for different reasons and end up
> in the err tag. Make sure we at least make sure we always free
> the mcb_device allocated with mcb_alloc_dev().
>
> If mcb_device_register() fails, make sure to give up the reference
> in the same place the device was added.
>
> Fixes: 728ac3389296 ("mcb: mcb-parse: fix error handing in chameleon_parse_gdd()")
> Reviewed-by: Jose Javier Rodriguez Barbarin <JoseJavier.Rodriguez@...gon.com>
> Signed-off-by: Jorge Sanjuan Garcia <jorge.sanjuangarcia@...gon.com>
Reviewed-by: Yang Yingliang <yangyingliang@...wei.com>