linux-kernel - Re: [PATCH drm-misc-next v2 6/7] drm/gpuvm: generalize dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202309070844.arxMNmRa-lkp@intel.com>
Date:   Thu, 7 Sep 2023 08:12:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Danilo Krummrich <dakr@...hat.com>, airlied@...il.com,
        daniel@...ll.ch, matthew.brost@...el.com,
        thomas.hellstrom@...ux.intel.com, sarah.walker@...tec.com,
        donald.robson@...tec.com, boris.brezillon@...labora.com,
        christian.koenig@....com, faith.ekstrand@...labora.com
Cc:     oe-kbuild-all@...ts.linux.dev, nouveau@...ts.freedesktop.org,
        Danilo Krummrich <dakr@...hat.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH drm-misc-next v2 6/7] drm/gpuvm: generalize
 dma_resv/extobj handling and GEM validation

Hi Danilo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 6bd3d8da51ca1ec97c724016466606aec7739b9f]

url:    https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-gpuva_mgr-allow-building-as-module/20230907-054931
base:   6bd3d8da51ca1ec97c724016466606aec7739b9f
patch link:    https://lore.kernel.org/r/20230906214723.4393-7-dakr%40redhat.com
patch subject: [PATCH drm-misc-next v2 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation
config: riscv-defconfig (https://download.01.org/0day-ci/archive/20230907/202309070844.arxMNmRa-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230907/202309070844.arxMNmRa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309070844.arxMNmRa-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_gpuva_mgr.c:998: warning: Function parameter or member 'exec' not described in 'drm_gpuvm_resv_add_fence'


vim +998 drivers/gpu/drm/drm_gpuva_mgr.c

   983	
   984	/**
   985	 * drm_gpuvm_resv_add_fence - add fence to private and all extobj
   986	 * dma-resv
   987	 * @gpuvm: the &drm_gpuvm to add a fence to
   988	 * @fence: fence to add
   989	 * @private_usage: private dma-resv usage
   990	 * @extobj_usage: extobj dma-resv usage
   991	 */
   992	void
   993	drm_gpuvm_resv_add_fence(struct drm_gpuvm *gpuvm,
   994				 struct drm_exec *exec,
   995				 struct dma_fence *fence,
   996				 enum dma_resv_usage private_usage,
   997				 enum dma_resv_usage extobj_usage)
 > 998	{
   999		struct drm_gem_object *obj;
  1000		unsigned long index;
  1001	
  1002		drm_exec_for_each_locked_object(exec, index, obj) {
  1003				dma_resv_assert_held(obj->resv);
  1004				dma_resv_add_fence(obj->resv, fence,
  1005						   drm_gpuvm_is_extobj(gpuvm, obj) ?
  1006						   private_usage : extobj_usage);
  1007		}
  1008	}
  1009	EXPORT_SYMBOL_GPL(drm_gpuvm_resv_add_fence);
  1010	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki