linux-kernel - RE: [PATCH v5 8/8] selftests/resctrl: Adjust effective L3 cache size when SNC enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB60839EB5CC3D172D864DF7A7FCEEA@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date:   Thu, 7 Sep 2023 16:19:37 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     "Shaopeng Tan (Fujitsu)" <tan.shaopeng@...itsu.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "Chatre, Reinette" <reinette.chatre@...el.com>,
        Peter Newman <peternewman@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        Shuah Khan <skhan@...uxfoundation.org>,
        "x86@...nel.org" <x86@...nel.org>
CC:     James Morse <james.morse@....com>,
        Jamie Iles <quic_jiles@...cinc.com>,
        Babu Moger <babu.moger@....com>,
        Randy Dunlap <rdunlap@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "patches@...ts.linux.dev" <patches@...ts.linux.dev>
Subject: RE: [PATCH v5 8/8] selftests/resctrl: Adjust effective L3 cache size
 when SNC enabled

> > +   if (4 * node_cpus >= cache_cpus)
> > +           return 4;
> > +   else if (2 * node_cpus >= cache_cpus)
> > +           return 2;
>
>
> If "4 * node_cpus >= cache_cpus " is not true，
> "2 * node_cpus >= cache_cpus" will never be true.
> Is it the following code?
>
> +     if (2 * node_cpus >= cache_cpus)
> +             return 2;
> +     else if (4 * node_cpus >= cache_cpus)
> +             return 4;


Shaopeng TAN,

Good catch. Your solution is the correct one.

Will fix in next post.

-Tony