linux-kernel - Re: [PATCH v2] ssb: Fix division by zero issue in ssb_calc_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169406641403.3946078.14931132240535951245.kvalo@kernel.org>
Date:   Thu,  7 Sep 2023 06:00:15 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Rand Deeb <rand.sec96@...il.com>
Cc:     Michael Buesch <m@...s.ch>, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org, deeb.rand@...fident.ru,
        lvc-project@...uxtesting.org, voskresenski.stanislav@...fident.ru,
        Rand Deeb <rand.sec96@...il.com>
Subject: Re: [PATCH v2] ssb: Fix division by zero issue in ssb_calc_clock_rate

Rand Deeb <rand.sec96@...il.com> wrote:

> In ssb_calc_clock_rate(), there is a potential issue where the value of
> m1 could be zero due to initialization using clkfactor_f6_resolv(). This
> situation raised concerns about the possibility of a division by zero
> error.
> 
> We fixed it by following the suggestions provided by Larry Finger
> <Larry.Finger@...inger.net> and Michael Büsch <m@...s.ch>. The fix
> involves returning a value of 1 instead of 0 in clkfactor_f6_resolv().
> This modification ensures the proper functioning of the code and
> eliminates the risk of division by zero errors.
> 
> Signed-off-by: Rand Deeb <rand.sec96@...il.com>
> Acked-by: Larry Finger <Larry.Finger@...inger.net>
> Acked-by: Michael Büsch <m@...s.ch>

Patch applied to wireless-next.git, thanks.

e0b5127fa134 ssb: Fix division by zero issue in ssb_calc_clock_rate

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230904232346.34991-1-rand.sec96@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches