linux-kernel - Re: [PATCH] gpiolib: remove unnecessary extern specifiers from the driver header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbDkBUhP-ZaWaErr3MqjGgSyei0EUD7PR3URs6h_ZWMUQ@mail.gmail.com>
Date:   Thu, 7 Sep 2023 09:44:57 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] gpiolib: remove unnecessary extern specifiers from the
 driver header

On Fri, Sep 1, 2023 at 1:35 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> 'extern' doesn't do anything for function declarations. Remove it.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Right I guess it should never be in headers, the one place
where is makes sense is if you're suddenly exporting something
in a C file, such as to expose it to assembly.

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij