linux-kernel - Re: [PATCH 2/2] checkpatch: reword long-line warning about commit-msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80524052652a85d2efdd3e2a01e7582baf9e545b.camel@perches.com>
Date:   Thu, 07 Sep 2023 11:19:17 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jim Cromie <jim.cromie@...il.com>, linux-kernel@...r.kernel.org
Cc:     akpm@...ux-foundation.org, apw@...onical.com,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH 2/2] checkpatch: reword long-line warning about
 commit-msg

On Thu, 2023-09-07 at 11:45 -0600, Jim Cromie wrote:
> The COMMIT_LOG_LONG_LINE warning complains about:
>  1- possible unwrapped commit description
>  2- line too long
> 
> The actual test is #2, so reword it to say that 1st.
> This could reduce potential confusion for newbie users.

I don't see this as valuable.

> 
> Cc: apw@...onical.com
> Cc: joe@...ches.com
> Cc: Kees Cook <keescook@...omium.org>
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6aabcc1f66c1..6e789dc07420 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3272,7 +3272,7 @@ sub process {
>  					# A Fixes:, link or signature tag line
>  		      $commit_log_possible_stack_dump)) {
>  			WARN("COMMIT_LOG_LONG_LINE",
> -			     "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
> +			     "Prefer a maximum 75 chars per line (possible unwrapped commit description?)\n" . $herecurr);
>  			$commit_log_long_line = 1;
>  		}
>