linux-kernel - Re: [PATCH net] net: enetc: distinguish error from valid pointers in enetc_fixup_clear_rss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169411142477.4092.10947806557916457815.git-patchwork-notify@kernel.org>
Date:   Thu, 07 Sep 2023 18:30:24 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, claudiu.manoil@....com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, linux-kernel@...r.kernel.org,
        dan.carpenter@...aro.org
Subject: Re: [PATCH net] net: enetc: distinguish error from valid pointers in
 enetc_fixup_clear_rss_rfs()

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed,  6 Sep 2023 17:16:09 +0300 you wrote:
> enetc_psi_create() returns an ERR_PTR() or a valid station interface
> pointer, but checking for the non-NULL quality of the return code blurs
> that difference away. So if enetc_psi_create() fails, we call
> enetc_psi_destroy() when we shouldn't. This will likely result in
> crashes, since enetc_psi_create() cleans up everything after itself when
> it returns an ERR_PTR().
> 
> [...]

Here is the summary with links:
  - [net] net: enetc: distinguish error from valid pointers in enetc_fixup_clear_rss_rfs()
    https://git.kernel.org/netdev/net/c/1b36955cc048

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html