linux-kernel - Re: [PATCH 2/7] fbdev/mmp/mmpfb: Do not display boot-up logo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d001e59-be78-3de8-25a3-087dcd19d58a@suse.de>
Date:   Thu, 7 Sep 2023 08:56:23 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Javier Martinez Canillas <javierm@...hat.com>, deller@....de,
        daniel@...ll.ch, sam@...nborg.org, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] fbdev/mmp/mmpfb: Do not display boot-up logo

Hi Javier

Am 06.09.23 um 11:54 schrieb Javier Martinez Canillas:
> Thomas Zimmermann <tzimmermann@...e.de> writes:
> 
>> The fbcon module takes care of displaying the logo, if any. Remove
>> the code form mmpfb. If we want to display the logo without fbcon,
> 
> s/form/from
> 
>> we should implement this in the fbdev core code.
>>
> 
> The commit message says the same than patch #1 but the driver will behave
> differently right? That is, won't only show the logo when fbcon is not
> enabled but unconditionally? So the logo will be duplicated when fbcon is
> enabled?
> 
> If I understood that correctly, probably you should mention that in the
> commit message since removing the fb_show_logo() will make the driver to
> behave correctly.

TBH I don't understand what happens here if the console and the logo has 
been enabled at the same time. AFAIK fbcon respects display rotation, 
but this driver doesn't. So the logo shows up in the wrong place then?

> 
>> Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
>> ---
> 
> Acked-by: Javier Martinez Canillas <javierm@...hat.com>
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)