linux-kernel - Re: [PATCH v2] pci: loongson: Workaround MIPS firmware MRRS settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Sep 2023 11:13:00 +0800
From:   Jiaxun Yang <jiaxun.yang@...goat.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     Huacai Chen <chenhuacai@...nel.org>, linux-pci@...r.kernel.org,
        bhelgaas@...gle.com, linux-kernel@...r.kernel.org, kw@...ux.com,
        lpieralisi@...nel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] pci: loongson: Workaround MIPS firmware MRRS settings

在 2023/9/7 9:18, Manivannan Sadhasivam 写道:
[...]
> Why do you need to walk through every single device instead of just bridges?
> I'm not the maintainer, but my suggestion is to go for Huacai Chen's solution.
Hi Mani,

Thanks for your reply, unfortunately Huacai's solution is impractical in 
this case.

The problem we have, is firmware (or BIOS) setting improper MRRS for devices
attached under those bridges. So we have to fix up MRRS for every single 
device.
We can't iterate child device in bridge quirk because there is no 
guarantee that
bridge will be probed before  it's child device, partly due to hotplug.

This quirk has been in tree for a while, until Huacai refactored it and 
broke some
systems in 8b3517f88ff2 ("PCI: loongson: Prevent LS7A MRRS increases").

Also to note that ks_pcie_quirk in drivers/pci/controller/dwc/pci-keystone.c
uses similar approach.
> This avoids iterating over bridges/devices two times.
>
> Also, please rename firmware to BIOS, as firmware commonly represents the
> software running on PCIe endpoint devices.
Ack, will fix in next reversion.

Thanks
- Jiaxun
>
> - Mani
[...]