linux-kernel - Re: [PATCH] firmware: ti_sci: Mark driver as non removable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230907205427.tilwp6fk2q7hpfof@pengutronix.de>
Date:   Thu, 7 Sep 2023 22:54:27 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Dhruva Gole <d-gole@...com>
Cc:     Nishanth Menon <nm@...com>, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Tero Kristo <kristo@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>, vibhore@...com
Subject: Re: [PATCH] firmware: ti_sci: Mark driver as non removable

Hello,

On Thu, Sep 07, 2023 at 10:47:00PM +0530, Dhruva Gole wrote:
> The TI-SCI message protocol provides a way to communicate between
> various compute processors with a central system controller entity. It
> provides the fundamental device management capability and clock control
> in the SOCs that it's used in.
> 

Maybe add:

	The remove function failed to do all the necessary cleanup if
	there are registered users. Some things are freed however which
	likely results in an oops later on.

> Ensure that the driver isn't unbound by suppressing its bind and unbind
> sysfs attributes. As the driver is built-in there is no way to remove
> device once bound.
> 
> We can also remove the ti_sci_remove call along with the
> ti_sci_debugfs_destroy as there are no callers for it any longer.
> 
> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Signed-off-by: Dhruva Gole <d-gole@...com>

While this isn't the most elegant solution, this is probably the most
feasible one.

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

(with or without the suggested addition to the commit log above).

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)