linux-kernel - Re: [PATCH v2 2/2] PCI: altera: add suport for Agilex Family FPGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230908194842.GA304176@bhelgaas>
Date:   Fri, 8 Sep 2023 14:48:42 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     "D M, Sharath Kumar" <sharath.kumar.d.m@...el.com>
Cc:     "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
        "kw@...ux.com" <kw@...ux.com>, "robh@...nel.org" <robh@...nel.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "dinguyen@...nel.org" <dinguyen@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] PCI: altera: add suport for Agilex Family FPGA

On Fri, Sep 08, 2023 at 02:35:29PM +0000, D M, Sharath Kumar wrote:
> > -----Original Message-----
> > From: Bjorn Helgaas <helgaas@...nel.org>
> > Sent: Friday, September 8, 2023 6:17 PM
> > To: D M, Sharath Kumar <sharath.kumar.d.m@...el.com>
> > Cc: lpieralisi@...nel.org; kw@...ux.com; robh@...nel.org;
> > bhelgaas@...gle.com; linux-pci@...r.kernel.org; dinguyen@...nel.org;
> > linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH v2 2/2] PCI: altera: add suport for Agilex Family FPGA
> > 
> > On Fri, Sep 08, 2023 at 09:15:09AM +0000, D M, Sharath Kumar wrote:
> > > > -----Original Message-----
> > > > From: Bjorn Helgaas <helgaas@...nel.org>
> > 
> > > > > +static u32 port_conf_off;
> > > >
> > > > port_conf_off looks like something that should be per-controller.
> > > Specific to agilex, will rename to "aglx_port_conf_off"
> > 
> > This comment was not about the *name*, it was about the fact that it's a
> > single instance that applies to *all* controllers.  It might be the case that
> > current hardware only supports a single controller, or that if you have
> > multiple controllers they all use the same port_conf_off value, but for
> > generality, values like this would normally be in the per-controller structure.
>
> This driver supports 3 controllers/family ( arria, startix, agilex )
> This variable is only for agilex
> What is ur suggestion ?
> To add in controller data structure (struct altera_pcie_data) ? 

That seems like a logical place.