linux-kernel - Re: [PATCH] LoongArch: Add tlb_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202309090624.CrkoQ4fj-lkp@intel.com>
Date:   Sat, 9 Sep 2023 06:43:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Bibo Mao <maobibo@...ngson.cn>, Huacai Chen <chenhuacai@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Add tlb_flush_threshold for tlb flush range

Hi Bibo,

kernel test robot noticed the following build errors:

[auto build test ERROR on 744a759492b5c57ff24a6e8aabe47b17ad8ee964]

url:    https://github.com/intel-lab-lkp/linux/commits/Bibo-Mao/LoongArch-Add-tlb_flush_threshold-for-tlb-flush-range/20230908-093017
base:   744a759492b5c57ff24a6e8aabe47b17ad8ee964
patch link:    https://lore.kernel.org/r/20230908012907.2994001-1-maobibo%40loongson.cn
patch subject: [PATCH] LoongArch: Add tlb_flush_threshold for tlb flush range
config: loongarch-randconfig-r021-20230909 (https://download.01.org/0day-ci/archive/20230909/202309090624.CrkoQ4fj-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230909/202309090624.CrkoQ4fj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309090624.CrkoQ4fj-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/loongarch/mm/tlb.c: In function '__update_hugetlb':
>> arch/loongarch/mm/tlb.c:146:14: error: implicit declaration of function 'pmd_to_entrylo' [-Werror=implicit-function-declaration]
     146 |         lo = pmd_to_entrylo(pte_val(*ptep));
         |              ^~~~~~~~~~~~~~
   arch/loongarch/mm/tlb.c: At top level:
   arch/loongarch/mm/tlb.c:259:6: warning: no previous prototype for 'setup_tlb_handler' [-Wmissing-prototypes]
     259 | void setup_tlb_handler(int cpu)
         |      ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/pmd_to_entrylo +146 arch/loongarch/mm/tlb.c

09cfefb7fa70c3 Huacai Chen 2022-05-31  131  
09cfefb7fa70c3 Huacai Chen 2022-05-31  132  static void __update_hugetlb(struct vm_area_struct *vma, unsigned long address, pte_t *ptep)
09cfefb7fa70c3 Huacai Chen 2022-05-31  133  {
29d05a2438754e Bibo Mao    2023-09-08  134  #if defined(CONFIG_HUGETLB_PAGE) || defined(CONFIG_TRANSPARENT_HUGEPAGE)
09cfefb7fa70c3 Huacai Chen 2022-05-31  135  	int idx;
09cfefb7fa70c3 Huacai Chen 2022-05-31  136  	unsigned long lo;
09cfefb7fa70c3 Huacai Chen 2022-05-31  137  	unsigned long flags;
09cfefb7fa70c3 Huacai Chen 2022-05-31  138  
09cfefb7fa70c3 Huacai Chen 2022-05-31  139  	local_irq_save(flags);
09cfefb7fa70c3 Huacai Chen 2022-05-31  140  
09cfefb7fa70c3 Huacai Chen 2022-05-31  141  	address &= (PAGE_MASK << 1);
09cfefb7fa70c3 Huacai Chen 2022-05-31  142  	write_csr_entryhi(address);
09cfefb7fa70c3 Huacai Chen 2022-05-31  143  	tlb_probe();
09cfefb7fa70c3 Huacai Chen 2022-05-31  144  	idx = read_csr_tlbidx();
09cfefb7fa70c3 Huacai Chen 2022-05-31  145  	write_csr_pagesize(PS_HUGE_SIZE);
09cfefb7fa70c3 Huacai Chen 2022-05-31 @146  	lo = pmd_to_entrylo(pte_val(*ptep));
09cfefb7fa70c3 Huacai Chen 2022-05-31  147  	write_csr_entrylo0(lo);
09cfefb7fa70c3 Huacai Chen 2022-05-31  148  	write_csr_entrylo1(lo + (HPAGE_SIZE >> 1));
09cfefb7fa70c3 Huacai Chen 2022-05-31  149  
09cfefb7fa70c3 Huacai Chen 2022-05-31  150  	if (idx < 0)
09cfefb7fa70c3 Huacai Chen 2022-05-31  151  		tlb_write_random();
09cfefb7fa70c3 Huacai Chen 2022-05-31  152  	else
09cfefb7fa70c3 Huacai Chen 2022-05-31  153  		tlb_write_indexed();
09cfefb7fa70c3 Huacai Chen 2022-05-31  154  	write_csr_pagesize(PS_DEFAULT_SIZE);
09cfefb7fa70c3 Huacai Chen 2022-05-31  155  
09cfefb7fa70c3 Huacai Chen 2022-05-31  156  	local_irq_restore(flags);
09cfefb7fa70c3 Huacai Chen 2022-05-31  157  #endif
09cfefb7fa70c3 Huacai Chen 2022-05-31  158  }
09cfefb7fa70c3 Huacai Chen 2022-05-31  159  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki