linux-kernel - Re: [PATCH 32/52] m68k: mac: Add and use "mac.h"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a126e21-6c36-024b-9ab1-b4798ef274d4@linux-m68k.org>
Date:   Sat, 9 Sep 2023 08:59:11 +1000 (AEST)
From:   Finn Thain <fthain@...ux-m68k.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
cc:     linux-m68k@...ts.linux-m68k.org, Arnd Bergmann <arnd@...db.de>,
        Michael Schmitz <schmitzmic@...il.com>,
        Philip Blundell <philb@....org>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        Joshua Thompson <funaho@...ai.org>,
        Sam Creasey <sammy@...my.net>,
        Laurent Vivier <laurent@...ier.eu>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 32/52] m68k: mac: Add and use "mac.h"

On Fri, 8 Sep 2023, Geert Uytterhoeven wrote:

> On Fri, Sep 8, 2023 at 1:44 AM Finn Thain <fthain@...ux-m68k.org> wrote:
> > On Thu, 7 Sep 2023, Geert Uytterhoeven wrote:
> > > --- /dev/null
> > > +++ b/arch/m68k/mac/mac.h
> > > @@ -0,0 +1,25 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> > > +
> > > +struct rtc_time;
> > > +
> >
> > I don't think we need a new header file. Related function prototypes
> > already have homes in existing header files --
> >
> > > +/* baboon.c */
> > > +void baboon_init(void);
> > > +
> >
> > this could go into mac_baboon.h
> >
> > > +/* iop.c */
> > > +void iop_init(void);
> > > +
> >
> > mac_iop.h
> >
> > > +/* misc.c */
> > > +int mac_hwclk(int op, struct rtc_time *t);
> > > +
> >
> > macintosh.h
> >
> > > +/* macboing.c */
> > > +void mac_mksound(unsigned int freq, unsigned int length);
> > > +
> >
> > mac_asc.h
> >
> > > +/* oss.c */
> > > +void oss_init(void);
> > > +
> >
> > mac_oss.h
> >
> > > +/* psc.c */
> > > +void psc_init(void);
> > > +
> >
> > mac_psc.h
> >
> > > +/* via.c */
> > > +void via_init(void);
> > > +void via_init_clock(void);
> >
> > mac_via.h
> 
> All mac*.h you suggest live under arch/m68k/include/asm/, and are thus 
> shared with the whole tree, while only the core code under arch/m68k/ 
> needs these definitions.
> 

I guess #include "../mac/mac.h" is expected but
#include "../../m68k/mac/mac.h" is not intended (?)