linux-kernel - Re: [PATCH v2] selftests/user_events: Fix failures when user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29fce076-746c-4650-8358-b4e0fa215cf7@sirena.org.uk>
Date:   Sat, 9 Sep 2023 00:33:05 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Beau Belgrave <beaub@...ux.microsoft.com>
Cc:     rostedt@...dmis.org, shuah@...nel.org, mhiramat@...nel.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        naresh.kamboju@...aro.org, anders.roxell@...aro.org, arnd@...db.de
Subject: Re: [PATCH v2] selftests/user_events: Fix failures when user_events
 is not installed

On Fri, Sep 08, 2023 at 08:19:16PM +0000, Beau Belgrave wrote:

> Add common methods to detect if tracefs and user_events is enabled. If
> either is not enabled skip the test. If tracefs is enabled, but is not
> mounted, mount tracefs and fail if there were any errors. Fail if not
> run as root.

This will leave tracefs mounted if it was not already mounted which is a
change to the system configuration.  While that may happen if things go
wrong during a test we should probably avoid actively doing this and
either only skip or try to umount at the end of the test if we mounted
ourselves.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)