linux-kernel - Re: [PATCH v15 08/12] nvmet: add copy command support for bdev and file ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e0271d9-d3a3-45cf-8ba7-fd4617fb6557@suse.de>
Date:   Fri, 8 Sep 2023 08:11:09 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Nitesh Shetty <nj.shetty@...sung.com>,
        Jens Axboe <axboe@...nel.dk>, Jonathan Corbet <corbet@....net>,
        Alasdair Kergon <agk@...hat.com>,
        Mike Snitzer <snitzer@...nel.org>, dm-devel@...hat.com,
        Keith Busch <kbusch@...nel.org>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>
Cc:     martin.petersen@...cle.com, mcgrof@...nel.org,
        gost.dev@...sung.com, Anuj Gupta <anuj20.g@...sung.com>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-nvme@...ts.infradead.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v15 08/12] nvmet: add copy command support for bdev and
 file ns

On 9/6/23 18:38, Nitesh Shetty wrote:
> Add support for handling nvme_cmd_copy command on target.
> 
> For bdev-ns if backing device supports copy offload we call device copy
> offload (blkdev_copy_offload).
> In case of partial completion from above or absence of device copy offload
> capability, we fallback to copy emulation (blkdev_copy_emulation)
> 
> For file-ns we call vfs_copy_file_range to service our request.
> 
> Currently target always shows copy capability by setting
> NVME_CTRL_ONCS_COPY in controller ONCS.
> 
> loop target has copy support, which can be used to test copy offload.
> trace event support for nvme_cmd_copy.
> 
> Signed-off-by: Nitesh Shetty <nj.shetty@...sung.com>
> Signed-off-by: Anuj Gupta <anuj20.g@...sung.com>
> ---
>   drivers/nvme/target/admin-cmd.c   |  9 ++-
>   drivers/nvme/target/io-cmd-bdev.c | 97 +++++++++++++++++++++++++++++++
>   drivers/nvme/target/io-cmd-file.c | 50 ++++++++++++++++
>   drivers/nvme/target/nvmet.h       |  4 ++
>   drivers/nvme/target/trace.c       | 19 ++++++
>   5 files changed, 177 insertions(+), 2 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@...e.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman