linux-kernel - Re: [RFC net-next v3 4/6] net: phy: nxp-c45-tja11xx: add MACsec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0825855e-4cff-31d9-82e9-2e428397111d@oss.nxp.com>
Date:   Fri, 8 Sep 2023 09:55:44 +0300
From:   "Radu Pirea (OSS)" <radu-nicolae.pirea@....nxp.com>
To:     Simon Horman <horms@...nel.org>
Cc:     andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, richardcochran@...il.com, sd@...asysnail.net,
        sebastian.tobuschat@....com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC net-next v3 4/6] net: phy: nxp-c45-tja11xx: add MACsec
 support


On 07.09.2023 18:00, Simon Horman wrote:
> On Wed, Sep 06, 2023 at 07:01:32PM +0300, Radu Pirea (NXP OSS) wrote:
>> +		sa = nxp_c45_find_sa(&pos->sa_list, TX_SA, encoding_sa);
>> +		if (!IS_ERR(sa))
>> +			macsec_pn_wrapped(pos->secy, sa->sa);
>> +		else
>> +			WARN_ON(!sa);
> 
> Hi Radu,
> 
> Smatch doesn't seem to think that sa can be NULL: it is either a valid
> pointer or an error pointer.

Thank you.
I was not able to reproduce the issue using smatch 1.73. With the master 
version worked.

-- 
Radu P.