[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <88c10e82-65bf-4610-9bcb-f7c5cc10570e@quicinc.com>
Date: Fri, 8 Sep 2023 15:18:16 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
<agross@...nel.org>, <andersson@...nel.org>,
<konrad.dybcio@...aro.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<tglx@...utronix.de>, <maz@...nel.org>, <lee@...nel.org>
CC: <robimarko@...il.com>, <quic_gurus@...cinc.com>,
<linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <quic_tsoni@...cinc.com>,
<quic_shashim@...cinc.com>, <quic_kaushalk@...cinc.com>,
<quic_tdas@...cinc.com>, <quic_tingweiz@...cinc.com>,
<quic_aiquny@...cinc.com>, <kernel@...cinc.com>,
<quic_bjorande@...cinc.com>, Ajit Pandey <quic_ajipan@...cinc.com>
Subject: Re: [PATCH 4/6] arm64: dts: qcom: sm4450: Add apps_rsc and cmd_db
node
在 9/8/2023 3:03 PM, Dmitry Baryshkov 写道:
> On 08/09/2023 09:58, Tengfei Fan wrote:
>> From: Ajit Pandey <quic_ajipan@...cinc.com>
>>
>> Add apps_rsc node and cmd_db memory region for sm4450.
>>
>> Signed-off-by: Ajit Pandey <quic_ajipan@...cinc.com>
>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sm4450.dtsi | 34 ++++++++++++++++++++++++++++
>> 1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm4450.dtsi
>> b/arch/arm64/boot/dts/qcom/sm4450.dtsi
>> index c4e5b33f5169..eb544d875806 100644
>> --- a/arch/arm64/boot/dts/qcom/sm4450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm4450.dtsi
>> @@ -5,6 +5,7 @@
>> #include <dt-bindings/gpio/gpio.h>
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +#include <dt-bindings/soc/qcom,rpmh-rsc.h>
>> / {
>> interrupt-parent = <&intc>;
>> @@ -328,6 +329,18 @@
>> };
>> };
>> + reserved_memory: reserved-memory {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
>> +
>> + aop_cmd_db_mem: cmd-db@...60000 {
>
> Judging from sm8550, this should be aop-cmd-db-region@....
Got below message when internal review this node name, so update to
cmd-db@...60000
"memory" is a "reserved word", so these nodes needs to be given a
non-generic name (contrary to all other cases), there was also a recent
cry from the maintainers that we don't need the "-region" suffix that
we've been using on recent platform.
>
>> + compatible = "qcom,cmd-db";
>> + reg = <0x0 0x80860000 0x0 0x20000>;
>> + no-map;
>> + };
>> + };
>> +
>> soc: soc@0 {
>> #address-cells = <2>;
>> #size-cells = <2>;
>> @@ -335,6 +348,27 @@
>> dma-ranges = <0 0 0 0 0x10 0>;
>> compatible = "simple-bus";
>> + apps_rsc: rsc@...00000 {
>> + label = "apps_rsc";
>> + compatible = "qcom,rpmh-rsc";
>> + reg = <0 0x17a00000 0 0x10000>,
>> + <0 0x17a10000 0 0x10000>,
>> + <0 0x17a20000 0 0x10000>;
>> + reg-names = "drv-0", "drv-1", "drv-2";
>> + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
>> + qcom,tcs-offset = <0xd00>;
>> + qcom,drv-id = <2>;
>> + qcom,tcs-config = <ACTIVE_TCS 2>, <SLEEP_TCS 3>,
>> + <WAKE_TCS 3>, <CONTROL_TCS 0>;
>> + power-domains = <&CLUSTER_PD>;
>> +
>> + apps_bcm_voter: bcm-voter {
>> + compatible = "qcom,bcm-voter";
>> + };
>> + };
>> +
>> tcsr_mutex: hwlock@...0000 {
>> compatible = "qcom,tcsr-mutex";
>> reg = <0x0 0x01f40000 0x0 0x40000>;
>
--
Thx and BRs,
Tengfei Fan
Powered by blists - more mailing lists