linux-kernel - Re: [PATCH v4 12/17] media: qcom: camss: Functionally decompose CSIPHY clock lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ea97401-34da-403c-a05d-e3bd7f891068@linaro.org>
Date:   Fri, 8 Sep 2023 11:21:41 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>, rfoss@...nel.org,
        todor.too@...il.com, agross@...nel.org, andersson@...nel.org,
        mchehab@...nel.org, hverkuil-cisco@...all.nl,
        laurent.pinchart@...asonboard.com, sakari.ailus@...ux.intel.com,
        andrey.konovalov@...aro.org
Cc:     linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 12/17] media: qcom: camss: Functionally decompose
 CSIPHY clock lookups

On 8.09.2023 11:20, Konrad Dybcio wrote:
> On 7.09.2023 18:44, Bryan O'Donoghue wrote:
>> The csiphyX_timer and csiX_phy values need not be hard-coded. We can
>> functionally decompose the string matching inside of a loop.
>>
>> Static string values are brittle, difficult to extend and not required
>> anyway since the camss->res->csiphy_num value informs us of the number
>> of CSIPHYs and hence the set of potential clocks for a given CSIPHY.
>>
>> In simple terms if we have five CSIPHYs we can have no more and no less
>> than five csiphy_timer clocks. Similarly csi_phy core clocks have a 1:1
>> relationship with the PHY they clock.
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>> ---
> Acked-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> 
> Konrad
Actually, well, I'm not sure about the breaks inside..

Konrad