linux-kernel - Re: [PATCH v4 16/17] media: qcom: camss: Propagate vfe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4bf890b-1e25-4041-9032-1ee138e0d691@linaro.org>
Date:   Fri, 8 Sep 2023 12:03:29 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>, rfoss@...nel.org,
        todor.too@...il.com, agross@...nel.org, andersson@...nel.org,
        mchehab@...nel.org, hverkuil-cisco@...all.nl,
        laurent.pinchart@...asonboard.com, sakari.ailus@...ux.intel.com,
        andrey.konovalov@...aro.org
Cc:     linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 16/17] media: qcom: camss: Propagate vfe_reset error up
 the callstack

On 7.09.2023 18:44, Bryan O'Donoghue wrote:
> A previous patch I had removed the returns from vfe_disable() since we
> didn't trap any meaningful errors. Konrad pointed out vfe_reset() could
> return an error, which is true.
> 
> Trap the vfe_reset() error code and throw it up the callstack.
> 
> Suggested-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad