[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <456ea951a34b3c599d990eddd15fee490fbaee37.camel@physik.fu-berlin.de>
Date: Fri, 08 Sep 2023 12:21:42 +0200
From: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Arnd Bergmann <arnd@...nel.org>, linux-sh@...r.kernel.org,
Rich Felker <dalias@...c.org>,
Yoshinori Sato <ysato@...rs.sourceforge.jp>,
linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 4/4] sh: machvec: remove custom ioport_{un,}map()
Hi Geert!
On Fri, 2023-09-08 at 12:20 +0200, Geert Uytterhoeven wrote:
> > Why aren't you removing the function ioport_unmap(void __iomem *addr) completely
> > and just turn it into stub? Is it still referenced somewhere?
>
> Because architectures are supposed to implement it (there is no
> __weak default).
>
> An alternative would be to provide a dummy static inline, like
> e.g. m68k does:
>
> arch/m68k/include/asm/kmap.h:#define ioport_unmap ioport_unmap
> arch/m68k/include/asm/kmap.h:static inline void ioport_unmap(void __iomem *p)
> arch/m68k/include/asm/kmap.h-{
> arch/m68k/include/asm/kmap.h-}
OK, that explains it. Thanks!
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Powered by blists - more mailing lists