linux-kernel - Re: [PATCH v4 15/17] media: qcom: camss: Move vfe_disable into a common routine where applicable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5d64d12-668a-4d70-85ee-e4111d85a1be@linaro.org>
Date:   Fri, 8 Sep 2023 12:24:49 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>, rfoss@...nel.org,
        todor.too@...il.com, agross@...nel.org, andersson@...nel.org,
        mchehab@...nel.org, hverkuil-cisco@...all.nl,
        laurent.pinchart@...asonboard.com, sakari.ailus@...ux.intel.com,
        andrey.konovalov@...aro.org
Cc:     linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 15/17] media: qcom: camss: Move vfe_disable into a
 common routine where applicable

On 8.09.2023 12:21, Bryan O'Donoghue wrote:
> On 08/09/2023 11:04, Konrad Dybcio wrote:
>> On 8.09.2023 12:02, Konrad Dybcio wrote:
>>> On 7.09.2023 18:44, Bryan O'Donoghue wrote:
>>>> We can move vfe_disable() into a common routine in the core VFE file
>>>> provided we make wm_stop() a VFE specific callback.
>>>>
>>>> The callback is required to capture the case where VFE 17x currently isn't
>>>> VC enabled where as VFE 480 is.
>>>>
>>>> Suggested-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>>>> ---
>>> Acked-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>>>
>>> Konrad
>> Actually there's
>>
>> ret = vfe_reset(vfe);
>>
>> return ret;
>>
>>
>> which could just be
>>
>> return vfe_reset(vfe);
>>
>>
>> Konrad
> 
> On purpose.
> 
> I prefer the ret = ; return ret; pattern since it makes it easier / less work to
> 
> ret = fn();
> if (ret)
>     goto error;
> 
> error:
>     return ret;
There's no error label in vfe_disable_output

Konrad