linux-kernel - Re: [PATCH v2] virtio-mmio: fix memory leak of vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230908113840.GA19696@dev-dsk-mheyne-1b-c1362c4d.eu-west-1.amazon.com>
Date:   Fri, 8 Sep 2023 11:38:40 +0000
From:   Maximilian Heyne <mheyne@...zon.de>
To:     Catalin Marinas <catalin.marinas@....com>
CC:     <virtualization@...ts.linux-foundation.org>,
        <stable@...r.kernel.org>, "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] virtio-mmio: fix memory leak of vm_dev

On Thu, Sep 07, 2023 at 05:28:25PM +0100, Catalin Marinas wrote:
> On Thu, Sep 07, 2023 at 02:17:16PM +0000, Maximilian Heyne wrote:
> > With the recent removal of vm_dev from devres its memory is only freed
> > via the callback virtio_mmio_release_dev. However, this only takes
> > effect after device_add is called by register_virtio_device. Until then
> > it's an unmanaged resource and must be explicitly freed on error exit.
> >
> > This bug was discovered and resolved using Coverity Static Analysis
> > Security Testing (SAST) by Synopsys, Inc.
> >
> > Cc: <stable@...r.kernel.org>
> > Fixes: 55c91fedd03d ("virtio-mmio: don't break lifecycle of vm_dev")
> > Signed-off-by: Maximilian Heyne <mheyne@...zon.de>
> 
> Reviewed-by: Catalin Marinas <catalin.marinas@....com>
> Tested-by: Catalin Marinas <catalin.marinas@....com>
> 
> Thanks.
> 
> --
> Catalin

Who would apply this patch? Something seems to have choked my patch so it didn't
reach lore.kernel.org (message couldn't be delivered due to timeout). Should I
try to send it again?



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879