[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAC=S1niYAC3PFQoAmwVc=1FcK29uu5sC9c1pGo-mku__y7eHcA@mail.gmail.com>
Date: Fri, 8 Sep 2023 19:51:00 +0800
From: Fei Shao <fshao@...omium.org>
To: Douglas Anderson <dianders@...omium.org>
Cc: dri-devel@...ts.freedesktop.org,
Maxime Ripard <mripard@...nel.org>, airlied@...il.com,
angelogioacchino.delregno@...labora.com, chunkuang.hu@...nel.org,
daniel@...ll.ch, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
matthias.bgg@...il.com, p.zabel@...gutronix.de
Subject: Re: [RFT PATCH 05/15] drm/mediatek: Call drm_atomic_helper_shutdown()
at shutdown time
Hi,
On Sat, Sep 2, 2023 at 7:42 AM Douglas Anderson <dianders@...omium.org> wrote:
...<snip>
> @@ -952,6 +960,7 @@ static const struct dev_pm_ops mtk_drm_pm_ops = {
> static struct platform_driver mtk_drm_platform_driver = {
> .probe = mtk_drm_probe,
> .remove = mtk_drm_remove,
I think this patch, and perhaps some others in this series, will have
a trivial conflict to Uwe's work about the remove callback conversion
e.g. [1], so you might want to rebase the series onto the latest
linux-next.
On the other hand, I tested this patch on MT8195 and MT8188
Chromebooks and I don't see issues during boot / reboot, so
Reviewed-by: Fei Shao <fshao@...omium.org>
Tested-by: Fei Shao <fshao@...omium.org>
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/commit/?h=mediatek-drm-next&id=b3af12a0b46888340e024ba8b231605bcf2d0ab3
> + .shutdown = mtk_drm_shutdown,
> .driver = {
> .name = "mediatek-drm",
> .pm = &mtk_drm_pm_ops,
> --
> 2.42.0.283.g2d96d420d3-goog
>
>
Powered by blists - more mailing lists