linux-kernel - Re: [PATCH 0/2] fs: fixes for multigrain ctime code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  8 Sep 2023 14:10:37 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     Christian Brauner <brauner@...nel.org>, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel test robot <oliver.sang@...el.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Jan Kara <jack@...e.cz>
Subject: Re: [PATCH 0/2] fs: fixes for multigrain ctime code

On Thu, 07 Sep 2023 12:33:46 -0400, Jeff Layton wrote:
> The kernel test robot noted some test failures with the LTP mount03 test
> on tmpfs. From the test output, it looked like the atime had gone
> backward.
> 
> One way this could happen would be for tmpfs to get a new inode from the
> slab that had a ctime that appeared to be in the future.
> inode_update_ctime_current would just return that time and then the
> mtime and atime would be set to the same value. Then later, the atime
> gets overwritten by "now" which is still lower than the garbage ctime
> value.
> 
> [...]

Picked up so we can get some -next testing. Hopefully that test thing can
verify the fix.

---

Applied to the vfs.ctime branch of the vfs/vfs.git tree.
Patches in the vfs.ctime branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.ctime

[1/2] fs: initialize inode->__i_ctime to the epoch
      https://git.kernel.org/vfs/vfs/c/7651a330dcbd
[2/2] fs: don't update the atime if existing atime is newer than "now"
      https://git.kernel.org/vfs/vfs/c/4c950d80d98d