linux-kernel - Re: [PATCH v5] hid-mcp2200: added driver for GPIOs of MCP2200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bkedv45j.fsf@protonmail.com>
Date:   Fri, 08 Sep 2023 01:34:53 +0000
From:   Rahul Rameshbabu <sergeantsagara@...tonmail.com>
To:     Johannes Roith <johannes@...-linux.rocks>
Cc:     ak@...klinger.de, andi.shyti@...nel.org,
        benjamin.tissoires@...hat.com, christophe.jaillet@...adoo.fr,
        jikos@...nel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, rdunlap@...radead.org
Subject: Re: [PATCH v5] hid-mcp2200: added driver for GPIOs of MCP2200

Hi Johannes,

On Thu, 07 Sep, 2023 18:41:21 +0200 "Johannes Roith" <johannes@...-linux.rocks> wrote:
> Hi Rahul,
>
> thank you for the explanation, now I got it.
>
> I have added hid_hw_stop and hid_hw_close to my remove function and removed the
> devm_add_action_or_reset. The driver still worked well.

Glad to hear this worked out. This discussion has motivated me to take a
deeper look at hid_device_remove in the near future to see what can be
done for devices that need to invoke hid_hw_open without needing to
explicitly implement a remove callback.

>
> So, if it is okay for you, I would go this way and generate a new patch.

This sounds great. Excited to see your patch on the mailing list.

--
Thanks,

Rahul Rameshbabu