linux-kernel - Re: [PATCH 0/3] arm64: dts: amlogic: add more basic audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00436bd2-5f3c-4fd6-9db8-799c541c6a33@linaro.org>
Date:   Fri, 8 Sep 2023 14:30:33 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Jerome Brunet <jbrunet@...libre.com>,
        Christian Hewitt <christianshewitt@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] arm64: dts: amlogic: add more basic audio support

Hi,

On 15/08/2023 11:37, Jerome Brunet wrote:
> 
> On Tue 15 Aug 2023 at 09:27, Christian Hewitt <christianshewitt@...il.com> wrote:
> 
>> This mini-series adds basic audio support to the P200/P201 (GXBB) and U200 (G12A)
>> reference boards. Few people likely have the original reference boards which have
>> extra audio capabilities, but the device-trees are widely [ab]used by users with
>> Android set-top boxes whose hardware is copy/pasted from the reference designs to
>> get working installs. Adding basic audio support does no harm to the real boards
>> and helps the secondary cause.
> 
> Still, this is something you have not tested on the u200 reference
> design. I believe this was already discussed in the past.
> 
> The u200 is far more complex when it comes to audio and certainly would
> not work on this no-name android device. These device are heavily
> "inspired" by the reference, but trimmed down in many aspect including
> audio capabilities - NOT copied.

I understand you point, but those changes only adds "internal" audio & basic spdif
capabilities so it won't affect the on-board audio electronics in any way.

> 
> People abusing the u200 or p200 DT does make the patchset valid

This is a reality, but still I think this patchset is valid and I'll
pick those since they are used for years out-of-tree and probably works
very fine in the reference design boards.

Neil

> 
>>
>> Christian Hewitt (3):
>>    arm64: dts: meson: add audio playback to p200
>>    arm64: dts: meson: add audio playback to p201
>>    arm64: dts: meson: add audio playback to u200
>>
>>   .../boot/dts/amlogic/meson-g12a-u200.dts      | 129 ++++++++++++++++++
>>   .../boot/dts/amlogic/meson-gxbb-p200.dts      |  60 ++++++++
>>   .../boot/dts/amlogic/meson-gxbb-p201.dts      |  39 ++++++
>>   3 files changed, 228 insertions(+)
>