linux-kernel - Re: [PATCH] ARM: mm: fix stack corruption when CONFIG_ARM_PV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY=EYQfRrUaw5JL5e0x2p=KurYfwvfunJ+GF1PmupKNqg@mail.gmail.com>
Date:   Fri, 8 Sep 2023 14:58:49 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Zhizhou Zhang <zhizhou.zh@...il.com>
Cc:     linux@...linux.org.uk, rmk+kernel@...linux.org.uk, rppt@...nel.org,
        akpm@...ux-foundation.org, vishal.moola@...il.com, arnd@...db.de,
        wangkefeng.wang@...wei.com, willy@...radead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Zhizhou Zhang <zhizhouzhang@...micro.com>
Subject: Re: [PATCH] ARM: mm: fix stack corruption when CONFIG_ARM_PV_FIXUP=y

Hi Zhizhou,

wow a great patch! I'm surprised no-one has been hit by this before.
I guess we were lucky.

On Thu, Sep 7, 2023 at 4:33 PM Zhizhou Zhang <zhizhou.zh@...il.com> wrote:

> From: Zhizhou Zhang <zhizhouzhang@...micro.com>
>
> flush_cache_all() save registers to stack at function entry.
> If it's called after cache disabled, the data is written to
> memory directly. So the following clean cache operation corrupted
> registers saved by flush_cache_all(), including lr register.
> calling flush_cache_all() before turn off cache fixed the problem.
>
> Signed-off-by: Zhizhou Zhang <zhizhouzhang@...micro.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

I would also add
Cc: stable@...r.kernel.org

Then please put this into Russell's patch tracker once review
is complete.

Yours,
Linus Walleij