linux-kernel - Re: [PATCH v2 04/11] ASoC: cs35l41: Fix broken shared boost activation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45aef3e9-b6ee-ba26-32ac-ea72f41d1dcb@opensource.cirrus.com>
Date:   Fri, 8 Sep 2023 10:15:02 -0500
From:   "Rhodes, David" <drhodes@...nsource.cirrus.com>
To:     Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
        James Schulman <james.schulman@...rus.com>,
        David Rhodes <david.rhodes@...rus.com>,
        "Richard Fitzgerald" <rf@...nsource.cirrus.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        "Mark Brown" <broonie@...nel.org>,
        Stefan Binding <sbinding@...nsource.cirrus.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
CC:     <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
        <linux-kernel@...r.kernel.org>, <kernel@...labora.com>
Subject: Re: [PATCH v2 04/11] ASoC: cs35l41: Fix broken shared boost
 activation

On 9/7/23 12:10 PM, Cristian Ciocaltea wrote:
> Enabling the active/passive shared boosts requires setting SYNC_EN, but
> *not* before receiving the PLL Lock signal.
> 

> Solve the issue by setting the SYNC_EN bit in PWR_CTRL3 register right
> after receiving the PLL Lock interrupt.
> 
> Additionally, drop the unnecessary writes to PWR_CTRL1 register, part of
> the original mdsync_up_seq, which would have toggled GLOBAL_EN with
> unwanted consequences on PLL locking behavior.
> 
> Fixes: f5030564938b ("ALSA: cs35l41: Add shared boost feature")
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
> ---

Looks good. If it's convenient to revise again, I think you could slim 
down the comment section by simply stating that 'PLL Lock requires the 
audio clocks to be active' (which is why it is not triggered until after 
snd_pcm_start).

Reviewed-by: David Rhodes <david.rhodes@...rus.com>

Thanks,
David