linux-kernel - Re: [PATCH] media: dvb: symbol fixup for dvb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZPtKCc2PLi0wdR2+@bombadil.infradead.org>
Date:   Fri, 8 Sep 2023 09:21:29 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable <stable@...nel.org>,
        Stefan Lippers-Hollmann <s.l-h@....de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Christoph Hellwig <hch@....de>, linux-media@...r.kernel.org,
        linux-modules@...r.kernel.org
Subject: Re: [PATCH] media: dvb: symbol fixup for dvb_attach()

On Fri, Sep 08, 2023 at 10:20:36AM +0100, Greg Kroah-Hartman wrote:
> In commit 9011e49d54dc ("modules: only allow symbol_get of
> EXPORT_SYMBOL_GPL modules") the use of symbol_get is properly restricted
> to GPL-only marked symbols.  This interacts oddly with the DVB logic
> which only uses dvb_attach() to load the dvb driver which then uses
> symbol_get().
> 
> Fix this up by properly marking all of the dvb_attach attach symbols as
> EXPORT_SYMBOL_GPL().
> 
> Fixes: 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules")
> Cc: stable <stable@...nel.org>
> Reported-by: Stefan Lippers-Hollmann <s.l-h@....de>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Christoph Hellwig <hch@....de>
> Cc: linux-media@...r.kernel.org
> Cc: linux-modules@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
> Luis, do you want to take this through your tree?  Or Mauro's?  Or I can
> take it through mine, it should get to Linus soon as this is causing
> regressions in his tree.

You've done the work so it is up to you, whatever helps you expedite it
as it already hit stable. Feel free to take it through your tree.

  Luis