linux-kernel - Re: [PATCH] drivers: nvdimm: fix possible memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43f5f3db-fe67-eb88-fc36-635d0ff63638@intel.com>
Date:   Fri, 8 Sep 2023 09:36:43 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Konstantin Meskhidze <konstantin.meskhidze@...wei.com>,
        <dan.j.williams@...el.com>
CC:     <vishal.l.verma@...el.com>, <ira.weiny@...el.com>,
        <peterz@...radead.org>, <kjain@...ux.ibm.com>, <maddy@...ibm.com>,
        <nvdimm@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
        <yusongping@...wei.com>, <artem.kuzin@...wei.com>
Subject: Re: [PATCH] drivers: nvdimm: fix possible memory leak



On 9/5/23 02:15, Konstantin Meskhidze wrote:
> Memory pointed by 'nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]->attrs[0]'
> is allocated in function 'nvdimm_pmu_cpu_hotplug_init' via
> 'create_cpumask_attr_group' call. But not released in function
> 'nvdimm_pmu_free_hotplug_memory' or anywhere else before memory pointed by
> 'nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]->attrs' will be freed.
> 
> Fixes: 0fab1ba6ad6b ("drivers/nvdimm: Add perf interface to expose nvdimm performance stats")
> Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@...wei-partners.com>
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@...wei.com>

Please change subject to something like below. It needs to be a bit more 
descriptive. Thank you!

nvdimm: Fix possible memory leak in nd_perf hotplug release


> ---
>   drivers/nvdimm/nd_perf.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/nvdimm/nd_perf.c b/drivers/nvdimm/nd_perf.c
> index 2b6dc80d8..ecfa1f635 100644
> --- a/drivers/nvdimm/nd_perf.c
> +++ b/drivers/nvdimm/nd_perf.c
> @@ -264,10 +264,14 @@ static void nvdimm_pmu_free_hotplug_memory(struct nvdimm_pmu *nd_pmu)
>   {
>   	cpuhp_state_remove_instance_nocalls(nd_pmu->cpuhp_state, &nd_pmu->node);
>   	cpuhp_remove_multi_state(nd_pmu->cpuhp_state);
>   
> -	if (nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR])
> +	if (nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]) {
> +		if (nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]->attrs)
> +			kfree(nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]->attrs[0]);
> +
>   		kfree(nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]->attrs);
> +	}
>   	kfree(nd_pmu->pmu.attr_groups[NVDIMM_PMU_CPUMASK_ATTR]);
>   }
>   
>   int register_nvdimm_pmu(struct nvdimm_pmu *nd_pmu, struct platform_device *pdev)