linux-kernel - Re: [PATCH net v2] ethtool: plca: fix plca enable data type while parsing the value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f6a8641-7151-368a-7529-721209c8af49@microchip.com>
Date:   Fri, 8 Sep 2023 04:35:38 +0000
From:   <Parthiban.Veerasooran@...rochip.com>
To:     <kuba@...nel.org>
CC:     <piergiorgio.beruto@...il.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <pabeni@...hat.com>, <andrew@...n.ch>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <Horatiu.Vultur@...rochip.com>, <Woojung.Huh@...rochip.com>,
        <Nicolas.Ferre@...rochip.com>, <Thorsten.Kummermehr@...rochip.com>,
        <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net v2] ethtool: plca: fix plca enable data type while
 parsing the value

Hi Jakub,

On 08/09/23 9:14 am, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, 8 Sep 2023 19:33:46 +0530 Parthiban Veerasooran wrote:
>> The ETHTOOL_A_PLCA_ENABLED data type is u8. But while parsing the
>> value from the attribute, nla_get_u32() is used in the plca_update_sint()
>> function instead of nla_get_u8(). So plca_cfg.enabled variable is updated
>> with some garbage value instead of 0 or 1 and always enables plca even
>> though plca is disabled through ethtool application. This bug has been
>> fixed by parsing the values based on the attributes type in the policy.
>>
>> Fixes: 8580e16c28f3 ("net/ethtool: add netlink interface for the PLCA RS")
>> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@...rochip.com>
> 
> One second look you need to fix the date on your system and resend.
> The patch came to us with a date 24h in the future it will confuse
> patchwork.
Sorry, by mistake the date has been set one day ahead. I will correct it 
and resend the patch now.

Best Regards,
Parthiban V
>