linux-kernel - Re: [PATCH 4/6] selinux: simplify avtab slot calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEjxPJ7YwHVjkOerYcDuSWLEFrxv01V4C9osvDt-1AXR+as+3g@mail.gmail.com>
Date:   Fri, 8 Sep 2023 14:44:35 -0400
From:   Stephen Smalley <stephen.smalley.work@...il.com>
To:     Christian Göttsche <cgzones@...glemail.com>
Cc:     selinux@...r.kernel.org, Paul Moore <paul@...l-moore.com>,
        Eric Paris <eparis@...isplace.org>,
        Ondrej Mosnacek <omosnace@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] selinux: simplify avtab slot calculation

On Fri, Aug 18, 2023 at 11:12 AM Christian Göttsche
<cgzones@...glemail.com> wrote:
>
> Instead of dividing by 8 and then performing log2 by hand, use a more
> readable calculation.
>
> The behavior of rounddown_pow_of_two() for an input of 0 is undefined,
> so handle that case and small values manually to achieve the same
> results.
>
> Signed-off-by: Christian Göttsche <cgzones@...glemail.com>

Reviewed-by: Stephen Smalley <stephen.smalley.work@...il.com>