linux-kernel - Re: [PATCH AUTOSEL 6.5 43/45] Fix nomenclature for USB and PCI wireless devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d2ddf90-2334-4d0c-9f63-018c150e06a9@rowland.harvard.edu>
Date:   Fri, 8 Sep 2023 15:12:26 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kalle Valo <kvalo@...nel.org>, quic_jjohnson@...cinc.com,
        nbd@....name, lorenzo@...nel.org, ryder.lee@...iatek.com,
        matthias.bgg@...il.com, kuba@...nel.org, srini.raju@...elifi.com,
        stf_xl@...pl, helmut.schaa@...glemail.com, pkshih@...ltek.com,
        corentin.chary@...il.com, hdegoede@...hat.com,
        markgross@...nel.org, johannes.berg@...el.com,
        alexander@...zel-home.de, error27@...il.com,
        szymon.heidrich@...il.com, gustavoars@...nel.org, lynxis@...0.eu,
        daniel@...rotopia.org, arnd@...db.de, shayne.chen@...iatek.com,
        keescook@...omium.org, tglx@...utronix.de, pabeni@...hat.com,
        rostedt@...dmis.org, jacob.e.keller@...el.com,
        ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        ath11k@...ts.infradead.org, ath12k@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        acpi4asus-user@...ts.sourceforge.net,
        platform-driver-x86@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH AUTOSEL 6.5 43/45] Fix nomenclature for USB and PCI
 wireless devices

On Fri, Sep 08, 2023 at 02:13:24PM -0400, Sasha Levin wrote:
> From: Alan Stern <stern@...land.harvard.edu>
> 
> [ Upstream commit 5d7cf67f72ae34d38e090bdfa673da4aefe4048e ]
> 
> A mouse that uses a USB connection is called a "USB mouse" device (or
> "USB mouse" for short), not a "mouse USB" device.  By analogy, a WiFi
> adapter that connects to the host computer via USB is a "USB wireless"
> device, not a "wireless USB" device.  (The latter term more properly
> refers to a defunct Wireless USB specification, which described a
> technology for sending USB protocol messages over an ultra wideband
> radio link.)
> 
> Similarly for a WiFi adapter card that plugs into a PCIe slot: It is a
> "PCIe wireless" device, not a "wireless PCIe" device.
> 
> Rephrase the text in the kernel source where the word ordering is
> wrong.
> 
> Signed-off-by: Alan Stern <stern@...land.harvard.edu>
> Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Kalle Valo <kvalo@...nel.org>
> Link: https://lore.kernel.org/r/57da7c80-0e48-41b5-8427-884a02648f55@rowland.harvard.edu
> Signed-off-by: Sasha Levin <sashal@...nel.org>


Is there any real reason to apply this commit to the -stable kernels?
I did not mark it that way when it was submitted, and it doesn't fix
any bugs.  In fact, aside from updating some module and device
description strings, all it does is change a bunch of comments.

Does that really fall under the -stable rules for acceptance?

Alan Stern