linux-kernel - Re: [PATCH V2 RESEND] iio: pressure: ms5637: Use i2c_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230910144305.17d7df5d@jic23-huawei>
Date:   Sun, 10 Sep 2023 14:43:05 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Biju Das <biju.das.jz@...renesas.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Biju Das <biju.das.au@...il.com>
Subject: Re: [PATCH V2 RESEND] iio: pressure: ms5637: Use
 i2c_get_match_data()

On Sun,  3 Sep 2023 15:59:26 +0100
Biju Das <biju.das.jz@...renesas.com> wrote:

> Simplify probe() by replacing id lookup for retrieving match data and
> device_get_match_data() by i2c_get_match_data().
> 
> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> v1->v2:
>  * Added Rb tag from Andy
>  * Dropped id variable removal from commit description.
Applied. Thanks,

> ---
>  drivers/iio/pressure/ms5637.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/pressure/ms5637.c b/drivers/iio/pressure/ms5637.c
> index 9b3abffb724b..ac30d76285d1 100644
> --- a/drivers/iio/pressure/ms5637.c
> +++ b/drivers/iio/pressure/ms5637.c
> @@ -144,7 +144,6 @@ static const struct iio_info ms5637_info = {
>  
>  static int ms5637_probe(struct i2c_client *client)
>  {
> -	const struct i2c_device_id *id = i2c_client_get_device_id(client);
>  	const struct ms_tp_data *data;
>  	struct ms_tp_dev *dev_data;
>  	struct iio_dev *indio_dev;
> @@ -159,10 +158,7 @@ static int ms5637_probe(struct i2c_client *client)
>  		return -EOPNOTSUPP;
>  	}
>  
> -	if (id)
> -		data = (const struct ms_tp_data *)id->driver_data;
> -	else
> -		data = device_get_match_data(&client->dev);
> +	data = i2c_get_match_data(client);
>  	if (!data)
>  		return -EINVAL;
>