linux-kernel - Re: [PATCH] staging: wlan-ng: prism2mgmt.c: remove needless parentheses to align with kernel coding style.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023091022-suggest-retract-c2b9@gregkh>
Date:   Sun, 10 Sep 2023 16:03:53 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Daniel Hammer <daniel.hammer120@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: prism2mgmt.c: remove needless
 parentheses to align with kernel coding style.

On Sun, Sep 10, 2023 at 06:05:53PM +0400, Daniel Hammer wrote:
> Remove unnecessary parentheses as detected by checkpatch.pl.
> 
> Signed-off-by: Daniel Hammer <daniel.hammer120@...il.com>
> ---
>  drivers/staging/wlan-ng/prism2mgmt.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index d5737166564e..201f07229962 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -1227,9 +1227,9 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
>  				     word, result);
>  				goto failed;
>  			}
> -			if ((msg->keepwepflags.status ==
> -			     P80211ENUM_msgitem_status_data_ok) &&
> -			    (msg->keepwepflags.data != P80211ENUM_truth_true)) {
> +			if (msg->keepwepflags.status ==
> +			     P80211ENUM_msgitem_status_data_ok &&
> +			    msg->keepwepflags.data != P80211ENUM_truth_true) {
>  				/* Set the wepflags for no decryption */
>  				word = HFA384x_WEPFLAGS_DISABLE_TXCRYPT |
>  				    HFA384x_WEPFLAGS_DISABLE_RXCRYPT;
> @@ -1249,9 +1249,9 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
>  		}
>  
>  		/* Do we want to strip the FCS in monitor mode? */
> -		if ((msg->stripfcs.status ==
> -		     P80211ENUM_msgitem_status_data_ok) &&
> -		    (msg->stripfcs.data == P80211ENUM_truth_true)) {
> +		if (msg->stripfcs.status ==
> +		     P80211ENUM_msgitem_status_data_ok &&
> +		    msg->stripfcs.data == P80211ENUM_truth_true) {
>  			hw->sniff_fcs = 0;
>  		} else {
>  			hw->sniff_fcs = 1;
> @@ -1288,9 +1288,9 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
>  
>  		/* Set the driver state */
>  		/* Do we want the prism2 header? */
> -		if ((msg->prismheader.status ==
> -		     P80211ENUM_msgitem_status_data_ok) &&
> -		    (msg->prismheader.data == P80211ENUM_truth_true)) {
> +		if (msg->prismheader.status ==
> +		     P80211ENUM_msgitem_status_data_ok &&
> +		    msg->prismheader.data == P80211ENUM_truth_true) {
>  			hw->sniffhdr = 0;
>  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
>  		} else if ((msg->wlanheader.status ==
> -- 
> 2.34.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You sent a patch that has been sent multiple times in the past few
  days, and is identical to ones that has been recently rejected.
  Please always look at the mailing list traffic to determine if you are
  duplicating other people's work.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot