linux-kernel - Re: [PATCH] mm: remove duplicated vma->vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230910142627.0dce42578bfaab7c4c67e316@linux-foundation.org>
Date:   Sun, 10 Sep 2023 14:26:27 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Xiu Jianfeng <xiujianfeng@...weicloud.com>
Cc:     Liam.Howlett@...cle.com, willy@...radead.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, xiujianfeng@...wei.com
Subject: Re: [PATCH] mm: remove duplicated vma->vm_flags check when
 expanding stack

On Wed,  6 Sep 2023 10:33:12 +0000 Xiu Jianfeng <xiujianfeng@...weicloud.com> wrote:

> expand_upwards() and expand_downwards() will return -EFAULT if VM_GROWSUP
> or VM_GROWSDOWN is not correctly set in vma->vm_flags, however in
> !CONFIG_STACK_GROWSUP case, expand_stack_locked() returns -EINVAL first
> if !(vma->vm_flags & VM_GROWSDOWN) before calling expand_downwards(), to
> keep the consistency with CONFIG_STACK_GROWSUP case, remove this check.

What are the user-visible effects of this change?

Do you believe this fix should be backported into earlier kernel versions?