linux-kernel - Re: [PATCH 10/11] ASoC: rsnd: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877coxd4zg.wl-kuninori.morimoto.gx@renesas.com>
Date:   Sun, 10 Sep 2023 22:43:22 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        kernel-janitors@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/11] ASoC: rsnd: add missing of_node_put


Hi Julia, Mark

Thank you for your feedback

> > I noticed that existing "of_node_put(node)" itself is not needed.
> > We can remove it, and I will post the patch next week.
> 
> Oops, indeed the better way to make the change would have been to convert
> node to ports.  It's just a copy paste error with respect to the code
> above the audio_graph label.  Do you want me to send this change instead?

No problem
"add missing no_node_put()" and "remove unneeded no_node_put()" are
mutual independent, it can be separate patch, I think.


Thank you for your help !!

Best regards
---
Kuninori Morimoto