| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202309100805.cRHktAYd-lkp@intel.com>
Date: Sun, 10 Sep 2023 08:31:44 +0800
From: kernel test robot <lkp@...el.com>
To: Alexander Potapenko <glider@...gle.com>, dvyukov@...gle.com,
elver@...gle.com, akpm@...ux-foundation.org, linux-mm@...ck.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
linux-kernel@...r.kernel.org, kasan-dev@...glegroups.com
Subject: Re: [PATCH 2/2] kmsan: prevent optimizations in memcpy tests
Hi Alexander,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.5 next-20230908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Alexander-Potapenko/kmsan-prevent-optimizations-in-memcpy-tests/20230907-210817
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20230907130642.245222-2-glider%40google.com
patch subject: [PATCH 2/2] kmsan: prevent optimizations in memcpy tests
config: x86_64-buildonly-randconfig-006-20230910 (https://download.01.org/0day-ci/archive/20230910/202309100805.cRHktAYd-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230910/202309100805.cRHktAYd-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309100805.cRHktAYd-lkp@intel.com/
All errors (new ones prefixed by >>):
>> mm/kmsan/kmsan_test.c:414:16: error: passing 'volatile void *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
return memcpy(dst, src, size);
^~~
arch/x86/include/asm/string_64.h:18:27: note: passing argument to parameter 'to' here
extern void *memcpy(void *to, const void *from, size_t len);
^
>> mm/kmsan/kmsan_test.c:414:21: error: passing 'const volatile void *' to parameter of type 'const void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
return memcpy(dst, src, size);
^~~
arch/x86/include/asm/string_64.h:18:43: note: passing argument to parameter 'from' here
extern void *memcpy(void *to, const void *from, size_t len);
^
>> mm/kmsan/kmsan_test.c:468:21: error: passing 'volatile int *' to parameter of type 'const void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
kmsan_check_memory(&uninit_src, sizeof(uninit_src));
^~~~~~~~~~~
include/linux/kmsan-checks.h:47:37: note: passing argument to parameter 'address' here
void kmsan_check_memory(const void *address, size_t size);
^
3 errors generated.
vim +414 mm/kmsan/kmsan_test.c
409
410 /* Prevent the compiler from inlining a memcpy() call. */
411 static noinline void *memcpy_noinline(volatile void *dst,
412 const volatile void *src, size_t size)
413 {
> 414 return memcpy(dst, src, size);
415 }
416
417 /* Test case: ensure that memcpy() correctly copies initialized values. */
418 static void test_init_memcpy(struct kunit *test)
419 {
420 EXPECTATION_NO_REPORT(expect);
421 volatile int src;
422 volatile int dst = 0;
423
424 src = 1;
425 kunit_info(
426 test,
427 "memcpy()ing aligned initialized src to aligned dst (no reports)\n");
428 memcpy_noinline((void *)&dst, (void *)&src, sizeof(src));
429 kmsan_check_memory((void *)&dst, sizeof(dst));
430 KUNIT_EXPECT_TRUE(test, report_matches(&expect));
431 }
432
433 /*
434 * Test case: ensure that memcpy() correctly copies uninitialized values between
435 * aligned `src` and `dst`.
436 */
437 static void test_memcpy_aligned_to_aligned(struct kunit *test)
438 {
439 EXPECTATION_UNINIT_VALUE_FN(expect, "test_memcpy_aligned_to_aligned");
440 volatile int uninit_src;
441 volatile int dst = 0;
442
443 kunit_info(
444 test,
445 "memcpy()ing aligned uninit src to aligned dst (UMR report)\n");
446 memcpy_noinline((void *)&dst, (void *)&uninit_src, sizeof(uninit_src));
447 kmsan_check_memory((void *)&dst, sizeof(dst));
448 KUNIT_EXPECT_TRUE(test, report_matches(&expect));
449 }
450
451 /*
452 * Test case: ensure that memcpy() correctly copies uninitialized values between
453 * aligned `src` and unaligned `dst`.
454 *
455 * Copying aligned 4-byte value to an unaligned one leads to touching two
456 * aligned 4-byte values. This test case checks that KMSAN correctly reports an
457 * error on the first of the two values.
458 */
459 static void test_memcpy_aligned_to_unaligned(struct kunit *test)
460 {
461 EXPECTATION_UNINIT_VALUE_FN(expect, "test_memcpy_aligned_to_unaligned");
462 volatile int uninit_src;
463 volatile char dst[8] = { 0 };
464
465 kunit_info(
466 test,
467 "memcpy()ing aligned uninit src to unaligned dst (UMR report)\n");
> 468 kmsan_check_memory(&uninit_src, sizeof(uninit_src));
469 memcpy_noinline((void *)&dst[1], (void *)&uninit_src,
470 sizeof(uninit_src));
471 kmsan_check_memory((void *)dst, 4);
472 KUNIT_EXPECT_TRUE(test, report_matches(&expect));
473 }
474
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists