linux-kernel - Re: [PATCH] selftests/nolibc: libc-test: avoid -Wstringop-overflow warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZP8kgXhP/UjsMoD4@1wt.eu>
Date:   Mon, 11 Sep 2023 16:30:25 +0200
From:   Willy Tarreau <w@....eu>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/nolibc: libc-test: avoid -Wstringop-overflow
 warnings

On Mon, Sep 11, 2023 at 04:26:41PM +0200, Thomas Weißschuh wrote:
> Hi Willy!
> 
> On 2023-09-11 08:04:49+0200, Willy Tarreau wrote:
> > On Sun, Sep 10, 2023 at 09:29:01PM +0200, Thomas Weißschuh wrote:
> > > Newer versions of glibc annotate the poll() function with
> > > __attribute__(access) which triggers a compiler warning inside the
> > > testcase poll_fault.
> > > Avoid this by using a plain NULL which is enough for the testcase.
> > > To avoid potential future warnings also adapt the other EFAULT
> > > testcases, except select_fault as NULL is a valid value for its
> > > argument.
> > (...)
> > 
> > Looks good to me. I wouldn't be surprised if we're soon forced to do
> > the same with select() on some archs where it might be emulated.
> > 
> > Feel free to push it to the shared repo.
> 
> Thanks, I pushed it to the "next" branch.
> 
> I'd also like to rebase the next branch onto v6.6-rc1, any objections?

Yes, please go on!

Thanks,
Willy