[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55b4b084-5b92-9e0d-9fa8-28a4062fb249@roeck-us.net>
Date: Mon, 11 Sep 2023 06:38:27 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Daniel Matyas <daniel.matyas@...log.com>
Cc: Jean Delvare <jdelvare@...e.com>, Rob Herring <robh+dt@...nel.org>,
Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Describe changes to the device
tree
On 9/11/23 01:37, Daniel Matyas wrote:
> Added new attributes to the device tree:
> - adi,comp-int
> - adi,alrm-pol
> - adi,flt-q
>
> These modify the corresponding bits in the configuration register.
>
> Signed-off-by: Daniel Matyas <daniel.matyas@...log.com>
> ---
> .../bindings/hwmon/adi,max31827.yaml | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> index 2dc8b07b4d3b..b10878c4a05d 100644
> --- a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> @@ -32,10 +32,28 @@ properties:
> Must have values in the interval (1.6V; 3.6V) in order for the device to
> function correctly.
>
> + adi,comp-int:
> + description:
> + A boolean property. If present interrupt mode is used. If not present
> + comparator mode is used (default).
> +
> + adi,alrm-pol:
> + description:
> + A boolean propert. If present, alarm is active on high. If not present,
property
> + alarm is active on low.
Is this the chip default ? That might be worth mentioning.
> +
> + adi,flt-q:
> + description:
> + Select how many consecutive temperature faults must occur before
> + overtemperature or undertemperature faults are indicated in the
> + corresponding status bits.
> + - can be 1, 2, 4 or 8
> +
> required:
> - compatible
> - reg
> - vref-supply
> + - adi,flt-q
I do not see a need to make this mandatory. Default can and should be the chip
default.
>
> additionalProperties: false
>
> @@ -49,6 +67,9 @@ examples:
> compatible = "adi,max31827";
> reg = <0x42>;
> vref-supply = <®_vdd>;
> + adi,comp-int;
> + adi,alrm-pol;
> + adi,flt-q = <1>;
> };
> };
> ...
Powered by blists - more mailing lists