[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BY5PR21MB1394F62601FEFE734181FFF7D6F2A@BY5PR21MB1394.namprd21.prod.outlook.com>
Date: Mon, 11 Sep 2023 18:57:21 +0000
From: Ajay Sharma <sharmaajay@...rosoft.com>
To: Leon Romanovsky <leon@...nel.org>,
"sharmaajay@...uxonhyperv.com" <sharmaajay@...uxonhyperv.com>
CC: Long Li <longli@...rosoft.com>, Jason Gunthorpe <jgg@...pe.ca>,
Dexuan Cui <decui@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Ajay Sharma <sharmaajay@...rosoft.com>
Subject: RE: [EXTERNAL] Re: [Patch v5 0/5] RDMA/mana_ib
I have updated the last patch to use xarray, will post the update patch. We currently use aux bus for ib device. Gd_register_device is firmware specific. All the patches use RDMA/mana_ib format which is aligned with drivers/infiniband/hw/mana/ .
Thanks
> -----Original Message-----
> From: Leon Romanovsky <leon@...nel.org>
> Sent: Monday, September 11, 2023 7:33 AM
> To: sharmaajay@...uxonhyperv.com
> Cc: Long Li <longli@...rosoft.com>; Jason Gunthorpe <jgg@...pe.ca>; Dexuan
> Cui <decui@...rosoft.com>; Wei Liu <wei.liu@...nel.org>; David S. Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; linux-
> rdma@...r.kernel.org; linux-hyperv@...r.kernel.org; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org; Ajay Sharma <sharmaajay@...rosoft.com>
> Subject: [EXTERNAL] Re: [Patch v5 0/5] RDMA/mana_ib
>
> On Thu, Sep 07, 2023 at 09:52:34AM -0700, sharmaajay@...uxonhyperv.com
> wrote:
> > From: Ajay Sharma <sharmaajay@...rosoft.com>
> >
> > Change from v4:
> > Send qp fatal error event to the context that created the qp. Add
> > lookup table for qp.
> >
> > Ajay Sharma (5):
> > RDMA/mana_ib : Rename all mana_ib_dev type variables to mib_dev
> > RDMA/mana_ib : Register Mana IB device with Management SW
> > RDMA/mana_ib : Create adapter and Add error eq
> > RDMA/mana_ib : Query adapter capabilities
> > RDMA/mana_ib : Send event to qp
>
> I didn't look very deep into the series and has three very initial comments.
> 1. Please do git log drivers/infiniband/hw/mana/ and use same format for
> commit messages.
> 2. Don't invent your own index-to-qp query mechanism in last patch and use
> xarray.
> 3. Once you decided to export mana_gd_register_device, it hinted me that it is
> time to move to auxbus infrastructure.
>
> Thanks
>
> >
> > drivers/infiniband/hw/mana/cq.c | 12 +-
> > drivers/infiniband/hw/mana/device.c | 81 +++--
> > drivers/infiniband/hw/mana/main.c | 288 +++++++++++++-----
> > drivers/infiniband/hw/mana/mana_ib.h | 102 ++++++-
> > drivers/infiniband/hw/mana/mr.c | 42 ++-
> > drivers/infiniband/hw/mana/qp.c | 86 +++---
> > drivers/infiniband/hw/mana/wq.c | 21 +-
> > .../net/ethernet/microsoft/mana/gdma_main.c | 152 +++++----
> > drivers/net/ethernet/microsoft/mana/mana_en.c | 3 +
> > include/net/mana/gdma.h | 16 +-
> > 10 files changed, 545 insertions(+), 258 deletions(-)
> >
> > --
> > 2.25.1
> >
Powered by blists - more mailing lists