linux-kernel - Re: [PATCH AUTOSEL 4.14 8/8] Bluetooth: btusb: Fix quirks table naming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZP7gd93uo1qdKOTd@duo.ucw.cz>
Date:   Mon, 11 Sep 2023 11:40:07 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Bastien Nocera <hadess@...ess.net>,
        Paul Menzel <pmenzel@...gen.mpg.de>,
        Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
        marcel@...tmann.org, johan.hedberg@...il.com, luiz.dentz@...il.com,
        linux-bluetooth@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14 8/8] Bluetooth: btusb: Fix quirks table
 naming

Hi!

> From: Bastien Nocera <hadess@...ess.net>
> 
> [ Upstream commit d831e3612111d385e8629104af5429808ef26e25 ]
> 
> The quirks table was named "blacklist_table" which isn't a good
> description for that table as devices detected using it weren't ignored
> by the driver.
> 
> Rename the table to match what it actually does.

Cleanup, not a bugfix. Don't need it in stable.

Best regards,
							Pavel

> +++ b/drivers/bluetooth/btusb.c
> @@ -186,7 +186,7 @@ static const struct usb_device_id btusb_table[] = {
>  
>  MODULE_DEVICE_TABLE(usb, btusb_table);
>  
> -static const struct usb_device_id blacklist_table[] = {
> +static const struct usb_device_id quirks_table[] = {
>  	/* CSR BlueCore devices */
>  	{ USB_DEVICE(0x0a12, 0x0001), .driver_info = BTUSB_CSR },
>  
> @@ -2963,7 +2963,7 @@ static int btusb_probe(struct usb_interface *intf,
>  	if (!id->driver_info) {
>  		const struct usb_device_id *match;
>  
> -		match = usb_match_id(intf, blacklist_table);
> +		match = usb_match_id(intf, quirks_table);
>  		if (match)
>  			id = match;
>  	}

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)