linux-kernel - Re: [PATCH v2 1/2] dt-bindings: i2c: Add custom properties for MAX7357/MAX7358

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Sep 2023 17:09:48 +0530
From:   Naresh Solanki <naresh.solanki@...ements.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Peter Rosin <peda@...ntia.se>, Andi Shyti <andi.shyti@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Patrick Rudolph <patrick.rudolph@...ements.com>,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: Add custom properties for MAX7357/MAX7358

Hi


On Mon, 11 Sept 2023 at 16:13, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 11/09/2023 12:31, Naresh Solanki wrote:
>
> >>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
> >>> index 2d7bb998b0e9..fa73eadfdf7b 100644
> >>> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
> >>> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
> >>> @@ -71,6 +71,23 @@ properties:
> >>>      description: A voltage regulator supplying power to the chip. On PCA9846
> >>>        the regulator supplies power to VDD2 (core logic) and optionally to VDD1.
> >>>
> >>> +  maxim,isolate-stuck-channel:
> >>> +    type: boolean
> >>> +    description: Allows to use non faulty channels while a stuck channel is
> >>> +      isolated from the upstream bus. If not set all channels are isolated from
> >>> +      the upstream bus until the fault is cleared.
> >>
> >> Nothing improved here. As I said, please provide arguments or drop this
> >> property.
> > These features cannot be enabled by default because doing so may lead
> > to unexpected behavior, such as bus disconnections(although that
> > wasn't expected).
> > These features should only be enabled after they have been validated
> > by the board designer.
> > Therefore, they cannot be enabled by default.
>
> And what is needed to validate them for given board? IOW, what changes
> in hardware design that it can or cannot be used?
Enabling PRECONNECT_TEST in my setup didn't work
Although this wasn't expected.

Regards,
Naresh

>
> Best regards,
> Krzysztof
>