linux-kernel - Re: [PATCH 08/11] thermal/of: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i46Ybd3KWQ-ogmbTRoTW=w1nDEg4KpVfo8x0ZFf3qOeg@mail.gmail.com>
Date:   Mon, 11 Sep 2023 17:12:45 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Julia Lawall <Julia.Lawall@...ia.fr>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        kernel-janitors@...r.kernel.org,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/11] thermal/of: add missing of_node_put

On Thu, Sep 7, 2023 at 11:56 AM Julia Lawall <Julia.Lawall@...ia.fr> wrote:
>
> for_each_child_of_node performs an of_node_get on each
> iteration, so a break out of the loop requires an
> of_node_put.
>
> This was done using the Coccinelle semantic patch
> iterators/for_each_child.cocci
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>
>
> ---
>  drivers/thermal/thermal_of.c |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff -u -p a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
> --- a/drivers/thermal/thermal_of.c
> +++ b/drivers/thermal/thermal_of.c
> @@ -37,8 +37,10 @@ static int of_find_trip_id(struct device
>          */
>         for_each_child_of_node(trips, t) {
>
> -               if (t == trip)
> +               if (t == trip) {
> +                       of_node_put(t);
>                         goto out;
> +               }
>                 i++;
>         }
>
> @@ -401,8 +403,10 @@ static int thermal_of_for_each_cooling_m
>
>         for_each_child_of_node(cm_np, child) {
>                 ret = thermal_of_for_each_cooling_device(tz_np, child, tz, cdev, action);
> -               if (ret)
> +               if (ret) {
> +                       of_node_put(child);
>                         break;
> +               }
>         }
>
>         of_node_put(cm_np);
>

Applied as 6.6-rc material, thanks!