[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZP7kHtc6B9rJmpcj@duo.ucw.cz>
Date: Mon, 11 Sep 2023 11:55:42 +0200
From: Pavel Machek <pavel@...x.de>
To: Sasha Levin <sashal@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
Niklas Schnelle <schnelle@...ux.ibm.com>,
Arnd Bergmann <arnd@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14 3/5] PCI: Make quirk using inw() depend on
HAS_IOPORT
Hi!
> From: Niklas Schnelle <schnelle@...ux.ibm.com>
>
> [ Upstream commit f768c75d61582b011962f9dcb9ff8eafb8da0383 ]
>
> In the future inw() and friends will not be compiled on architectures
> without I/O port support.
Yeah, in future. Not in stable. Please drop.
BR,
Pavel
> +++ b/drivers/pci/quirks.c
> @@ -102,6 +102,7 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NEC, PCI_DEVICE_ID_NEC_CBUS_1, quirk_isa_d
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NEC, PCI_DEVICE_ID_NEC_CBUS_2, quirk_isa_dma_hangs);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NEC, PCI_DEVICE_ID_NEC_CBUS_3, quirk_isa_dma_hangs);
>
> +#ifdef CONFIG_HAS_IOPORT
> /*
> * Intel NM10 "TigerPoint" LPC PM1a_STS.BM_STS must be clear
> * for some HT machines to use C4 w/o hanging.
> @@ -121,6 +122,7 @@ static void quirk_tigerpoint_bm_sts(struct pci_dev *dev)
> }
> }
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TGP_LPC, quirk_tigerpoint_bm_sts);
> +#endif
>
> /*
> * Chipsets where PCI->PCI transfers vanish or hang
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)
Powered by blists - more mailing lists